Skip to content

Comments

Using Eclipse temurin in GH actions#6995

Merged
Redirion merged 1 commit intoTeamNewPipe:devfrom
litetex:use-eclipse-temurin-in-gh-actions
Aug 27, 2021
Merged

Using Eclipse temurin in GH actions#6995
Redirion merged 1 commit intoTeamNewPipe:devfrom
litetex:use-eclipse-temurin-in-gh-actions

Conversation

@litetex
Copy link
Member

@litetex litetex commented Aug 27, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Using Eclipse temurin in GH actions as AdoptOpenJDK is getting deprecated.

Eclipse temurin is a de-facto renamed AdoptOpenJDK.

Ref:

Reasons why using Eclipse Temurin/Adoptium and not Zulu can be found here:

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@triallax triallax added the CI Everything related to CI (Continuous integration) label Aug 27, 2021
@Redirion Redirion merged commit 556aad0 into TeamNewPipe:dev Aug 27, 2021
@litetex litetex deleted the use-eclipse-temurin-in-gh-actions branch August 27, 2021 14:00
This was referenced Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Everything related to CI (Continuous integration)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants